Login or Signup

← Back to Task List

paltman
Assignee: paltman
State: new
Creator: paltman
Created: May 22, 2010
Modified: 3mn, 2wk ago
History of this Task
Nudges: 0

#664: don't require request and user in context

The django-flag app requires that both a variable named "user" and "request" be in context to use the flag template tag.

"user" is not referenced anywhere downstream of this requirement.

"request" is only needed to provide a way to inject the previous page into the next variable in the form.

I don't think that the "request" object should be required (out of the box pinax running the social project and blog app doesn't put the request object in context, for example). I also think most browsers will supply request.META['HTTP_REFERRER']. Therefore, I think we should degrade sanely if request isn't supplied, try the REFERRER to return them to the page they came from, or else then raise, not return, the 404.

Status: fixed in my clone

Comment

Please Login (or Sign Up) to leave a comment